ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm - Issue 2784943002: Remove matcher to wait for static HTML view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm

Issue 2784943002: Remove matcher to wait for static HTML view. (Closed)

Patch Set: typo Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm ('k') | ios/chrome/browser/ui/error_page_egtest.mm » ('j') | ios/chrome/test/earl_grey/chrome_earl_grey.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm

diff --git a/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm b/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm

index 9211cfff2d027798b84ebeb455e046164af3862b..52b3458ad43b6003da3327e2e51f1ba04884f4d1 100644

--- a/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm

+++ b/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm

@@ -73,11 +73,7 @@ id<GREYMatcher> PrintButton() {

// Open an error page.

[ChromeEarlGrey loadURL:ErrorPageResponseProvider::GetDnsFailureUrl()];

- NSString* const kError =

- l10n_util::GetNSString(IDS_ERRORPAGES_HEADING_NOT_AVAILABLE);

- [[EarlGrey

- selectElementWithMatcher:chrome_test_util::StaticHtmlViewContainingText(

- kError)] assertWithMatcher:grey_notNil()];

+ [ChromeEarlGrey waitForErrorPage];

// Execute the Print action.

[[EarlGrey selectElementWithMatcher:PrintButton()] performAction:grey_tap()];