ios/chrome/test/app/static_html_view_test_util.h - Issue 2784943002: Remove matcher to wait for static HTML view.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/test/app/static_html_view_test_util.h

Issue 2784943002: Remove matcher to wait for static HTML view. (Closed)

Patch Set: more better comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/web/navigation_egtest.mm ('K') | « ios/chrome/test/app/BUILD.gn ('k') | ios/chrome/test/app/static_html_view_test_util.mm » ('j') | ios/chrome/test/app/static_html_view_test_util.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_TEST_APP_STATIC_HTML_VIEW_TEST_UTIL_H_

	6 #define IOS_CHROME_TEST_APP_STATIC_HTML_VIEW_TEST_UTIL_H_

	7

	8 #import "ios/web/public/web_state/web_state.h"

	9

	10 namespace chrome_test_util {

	11

	12 // Returns true if there is a static html view in the \|web_state\|, which

	13 // contains \|text\|. If the text is not present, or there is no static html view

	14 // it returns false.

	15 bool StaticHtmlViewContainingText(web::WebState* web_state, std::string text);
	baxley 2017/03/31 20:59:22 I know you had a concern about having some methods I know you had a concern about having some methods that return bool, some that assert, some that wait, and some that don't. I think it's reasonable to have ios/chrome/test/app methods that do no waiting and just check a state. Then ChromeEarlGrey can do any waiting that is necessary. Eugene But (OOO till 7-30) 2017/03/31 22:19:17 I think this is fine. AFAIK, methods inside chrome Show quoted text On 2017/03/31 20:59:22, baxley wrote: > I know you had a concern about having some methods that return bool, some that > assert, some that wait, and some that don't. > > I think it's reasonable to have ios/chrome/test/app methods that do no waiting > and just check a state. Then ChromeEarlGrey can do any waiting that is > necessary. I think this is fine. AFAIK, methods inside chrome_test_util are not suppose to assert. baxley 2017/04/03 18:10:41 Yes, this comment was in response to an offline co Show quoted text On 2017/03/31 22:19:17, Eugene But wrote: > On 2017/03/31 20:59:22, baxley wrote: > > I know you had a concern about having some methods that return bool, some that > > assert, some that wait, and some that don't. > > > > I think it's reasonable to have ios/chrome/test/app methods that do no waiting > > and just check a state. Then ChromeEarlGrey can do any waiting that is > > necessary. > I think this is fine. AFAIK, methods inside chrome_test_util are not suppose to > assert. Yes, this comment was in response to an offline conversation about it being confusing to have some that wait, some that don't, some that assert, some that return bool. I think that didn't have the context of this, where it fits fine.
	16

	17 } // namespace chrome_test_util

	18

	19 #endif // IOS_CHROME_TEST_APP_STATIC_HTML_VIEW_TEST_UTIL_H_

OLD	NEW