components/url_formatter/top_domains/README - Issue 2784933002: Mitigate spoofing attempt using Latin letters.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/url_formatter/top_domains/README

Issue 2784933002: Mitigate spoofing attempt using Latin letters. (Closed)

Patch Set: pull IDNSpoofChecker to separae h/cc files Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 * alexa_domains.list

	2

	3 The Alexa top 10k domains, one per line, constructed by running

	4 make_alexa_top_list.py. Used as an input to make_top_domain_gperf.

	5 It's derived from

	6 src/tools/perf/page_sets/alexa1-10000-urls.json with make_alexa_top_list.py

	7

	8 * alexa_names_and_skeletons.gperf
	Peter Kasting 2017/05/10 22:38:47 Nit: File has been renamed? Nit: File has been renamed? jungshik at Google 2017/05/14 09:36:23 Corrected. Show quoted text On 2017/05/10 22:38:47, Peter Kasting wrote: > Nit: File has been renamed? Corrected.
	9

	10 The checked-in output of make_top_domain_gperf. Processed during the

	11 build to generate alexa_names_and_skeletons-inc.cc, which is used by

	12 url_formatter.cc. This must be regenerated as follows if ICU is updated, sinc e
	Peter Kasting 2017/05/10 22:38:47 Nit: 80 columns Nit: 80 columns jungshik at Google 2017/05/14 09:36:23 Done. Show quoted text On 2017/05/10 22:38:47, Peter Kasting wrote: > Nit: 80 columns Done.
	13 skeletons can differ across ICU versions:

	14

	15
	Peter Kasting 2017/05/10 22:38:47 Nit: Second blank line not needed Nit: Second blank line not needed jungshik at Google 2017/05/14 09:36:23 Done. Show quoted text On 2017/05/10 22:38:47, Peter Kasting wrote: > Nit: Second blank line not needed Done.
	16 $ ninja -C $build_outdir make_top_domain_gperf

	17 $ $build_outdir/make_top_domain_gperf

OLD	NEW