components/url_formatter/top_domains/README - Issue 2784933002: Mitigate spoofing attempt using Latin letters.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/url_formatter/top_domains/README

Issue 2784933002: Mitigate spoofing attempt using Latin letters. (Closed)

Patch Set: add back U+04CF (ӏ) -> 'l' map Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/url_formatter/top_domains/BUILD.gn ('K') | « components/url_formatter/top_domains/BUILD.gn ('k') | components/url_formatter/top_domains/alexa_domains.list » ('j') | components/url_formatter/top_domains/make_alexa_top_list.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 * alexa_domains.list

	2 It is an input to make_top_domain_list and is made up of list of Alexa
	Peter Kasting 2017/05/09 01:37:02 Nit: "The Alexa top 10k domains, one per line, con Nit: "The Alexa top 10k domains, one per line, constructed by running make_alexa_top_list.py. Used as an input to make_top_domain_gperf." I assume that "list" here and below should have been "gperf". Also, be consistent about whether or not to use a newline between the bulleted name above and the explanation here. jungshik at Google 2017/05/10 18:05:12 Thanks. Done Show quoted text On 2017/05/09 01:37:02, Peter Kasting wrote: > Nit: "The Alexa top 10k domains, one per line, constructed by running > make_alexa_top_list.py. Used as an input to make_top_domain_gperf." > > I assume that "list" here and below should have been "gperf". > > Also, be consistent about whether or not to use a newline between the bulleted > name above and the explanation here. Thanks. Done
	3 top 10k domains (one per line).

	4 It's derived from

	5 src/tools/perf/page_sets/alexa1-10000-urls.json with make_alexa_top_list.py

	6

	7 * alexa_names_and_skeletons.gperf

	8

	9 It is generated by running make_top_domain_list and checked in.
	Peter Kasting 2017/05/09 01:37:02 Nit: "The checked-in output of make_top_domain_gpe Nit: "The checked-in output of make_top_domain_gperf. Processed during the build to generate alexa_names_and_skeletons-inc.cc, which is used by url_formatter.cc. This must be regenerated as follows if ICU is updated, since skeletons can differ across ICU versions: <instructions>" This makes me wonder if there should be a README note in the ICU directory that says to regenerate this. jungshik at Google 2017/05/10 18:05:12 Thank you for a much better rewrite. Show quoted text On 2017/05/09 01:37:02, Peter Kasting wrote: > Nit: "The checked-in output of make_top_domain_gperf. Processed during the > build to generate alexa_names_and_skeletons-inc.cc, which is used by > url_formatter.cc. This must be regenerated as follows if ICU is updated, since > skeletons can differ across ICU versions: <instructions>" Thank you for a much better rewrite. Show quoted text > This makes me wonder if there should be a README note in the ICU directory that > says to regenerate this. I'll add it to README.chromium in third_party/icu.
	10 No command line argument needs to be passed.

	11

	12 When ICU is updated to a new major version, this file needs to be regenerated

	13 because skeletons can be different in different ICU versions.

	14

	15 $ ninja -C $build_outdir make_top_domain_gperf

	16 $ $build_outdir/make_top_domain_gperf

	17

	18 During a build, it is processed by net/tools/dafsa/make_dafsa.py to generate

	19 alexa_names_and_skeletons-inc.cc that is included by

	20 components/url_formatter/url_formatter.cc

OLD	NEW