Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: components/gcm_driver/gcm_driver_android.cc

Issue 278493002: Split GCMDriver into platform-specific implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed jianli's review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_android.cc
diff --git a/components/gcm_driver/gcm_driver_android.cc b/components/gcm_driver/gcm_driver_android.cc
index e7ae95598806aa49b8209ed125054d0122d7a3e0..91282b49c0f5c0203682ba3db77d21c0e3633b4b 100644
--- a/components/gcm_driver/gcm_driver_android.cc
+++ b/components/gcm_driver/gcm_driver_android.cc
@@ -5,6 +5,7 @@
#include "components/gcm_driver/gcm_driver_android.h"
#include "base/compiler_specific.h"
+#include "base/logging.h"
namespace gcm {
static void Java_GCMDriver_doNothing(JNIEnv* env) ALLOW_UNUSED;
@@ -15,6 +16,66 @@ static void Java_GCMDriver_doNothing(JNIEnv* env) ALLOW_UNUSED;
namespace gcm {
+GCMDriverAndroid::GCMDriverAndroid() {
+}
+
+GCMDriverAndroid::~GCMDriverAndroid() {
+}
+
+void GCMDriverAndroid::Enable() {
+}
+
+void GCMDriverAndroid::Disable() {
+}
+
+void GCMDriverAndroid::Register(const std::string& app_id,
+ const std::vector<std::string>& sender_ids,
+ const RegisterCallback& callback) {
+ // TODO(johnme): Hook up to Android GCM API via JNI.
+ NOTIMPLEMENTED();
+}
+
+void GCMDriverAndroid::Unregister(const std::string& app_id,
+ const UnregisterCallback& callback) {
+ // TODO(johnme): Hook up to Android GCM API via JNI.
+ NOTIMPLEMENTED();
+}
+
+void GCMDriverAndroid::Send(const std::string& app_id,
+ const std::string& receiver_id,
+ const GCMClient::OutgoingMessage& message,
+ const SendCallback& callback) {
+ NOTIMPLEMENTED();
+}
+
+GCMClient* GCMDriverAndroid::GetGCMClientForTesting() const {
+ NOTIMPLEMENTED();
+ return NULL;
+}
+
+bool GCMDriverAndroid::IsStarted() const {
+ return true;
+}
+
+bool GCMDriverAndroid::IsGCMClientReady() const {
+ return true;
+}
+
+void GCMDriverAndroid::GetGCMStatistics(
+ const GetGCMStatisticsCallback& callback,
+ bool clear_logs) {
+ NOTIMPLEMENTED();
+}
+
+void GCMDriverAndroid::SetGCMRecording(const GetGCMStatisticsCallback& callback,
+ bool recording) {
+ NOTIMPLEMENTED();
+}
+
+std::string GCMDriverAndroid::SignedInUserName() const {
+ return std::string();
+}
+
// static
bool GCMDriverAndroid::RegisterBindings(JNIEnv* env) {
return RegisterNativesImpl(env);

Powered by Google App Engine
This is Rietveld 408576698