Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.cc

Issue 278493002: Split GCMDriver into platform-specific implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix trybots Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc
index 74cad9fb0458a8678fb8aefde8b1943b647361e0..a94b202ab385905e802af924f8974b0b7a5b1680 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/gcm_profile_service.cc
@@ -4,26 +4,28 @@
#include "chrome/browser/services/gcm/gcm_profile_service.h"
-#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/pref_names.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+
+#if defined(OS_ANDROID)
+#include "components/gcm_driver/gcm_driver_android.h"
+#else
+#include "base/files/file_path.h"
#include "chrome/browser/services/gcm/gcm_utils.h"
#include "chrome/browser/signin/profile_identity_provider.h"
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/common/chrome_constants.h"
-#include "chrome/common/pref_names.h"
#include "components/gcm_driver/gcm_client_factory.h"
-#include "components/gcm_driver/gcm_driver.h"
-#include "components/pref_registry/pref_registry_syncable.h"
+#include "components/gcm_driver/gcm_driver_desktop.h"
#include "components/signin/core/browser/signin_manager.h"
#include "content/public/browser/browser_thread.h"
#include "google_apis/gaia/identity_provider.h"
#include "net/url_request/url_request_context_getter.h"
-
-#if !defined(OS_ANDROID)
-#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#endif
namespace gcm {
@@ -48,20 +50,18 @@ GCMProfileService::GCMProfileService(
: profile_(profile) {
DCHECK(!profile->IsOffTheRecord());
+#if defined(OS_ANDROID)
+ driver_.reset(new GCMDriverAndroid());
+#else
+ LoginUIService* login_ui_service =
+ LoginUIServiceFactory::GetForProfile(profile_);
scoped_refptr<base::SequencedWorkerPool> worker_pool(
content::BrowserThread::GetBlockingPool());
scoped_refptr<base::SequencedTaskRunner> blocking_task_runner(
worker_pool->GetSequencedTaskRunnerWithShutdownBehavior(
worker_pool->GetSequenceToken(),
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
-
-#if defined(OS_ANDROID)
- LoginUIService* login_ui_service = NULL;
-#else
- LoginUIService* login_ui_service =
- LoginUIServiceFactory::GetForProfile(profile_);
-#endif
- driver_.reset(new GCMDriver(
+ driver_.reset(new GCMDriverDesktop(
gcm_client_factory.Pass(),
scoped_ptr<IdentityProvider>(new ProfileIdentityProvider(
SigninManagerFactory::GetForProfile(profile_),
@@ -75,6 +75,7 @@ GCMProfileService::GCMProfileService(
content::BrowserThread::GetMessageLoopProxyForThread(
content::BrowserThread::IO),
blocking_task_runner));
+#endif
}
GCMProfileService::GCMProfileService() : profile_(NULL) {

Powered by Google App Engine
This is Rietveld 408576698