Split GCMDriver into platform-specific implementations

components/gcm.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'gcm',
       'type': 'static_library',
       'dependencies': [
         '../base/base.gyp:base',
         '../google_apis/gcm/gcm.gyp:gcm',
         '../net/net.gyp:net',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'gcm/default_gcm_app_handler.cc',
         'gcm/default_gcm_app_handler.h',
         'gcm/gcm_app_handler.h',
         'gcm/gcm_client_factory.cc',
         'gcm/gcm_client_factory.h',
         'gcm/gcm_driver.cc',
         'gcm/gcm_driver.h',
+        'gcm/gcm_driver_android.cc',
+        'gcm/gcm_driver_android.h',

[fgorski, 2014/05/07 18:50:14]

Would this compile the gcm_driver_android on desktop as well? If so, do we need
it?

[johnme, 2014/05/08 16:08:02]

No, *_android.* is only compiled on Android. See [1] (needs updating to mention
_android, but the same mechanism does work on Android). For gcm_driver_desktop,
I wasn't able to use that mechanism, so I used the preferred alternative
mechanism listed below on that page, which is to list it but then exclude it.

[1]:
https://code.google.com/p/gyp/wiki/GypUserDocumentation#Add_a_platform-specif...

+        'gcm/gcm_driver_desktop.cc',
+        'gcm/gcm_driver_desktop.h',
+      ],
+      'conditions': [
+        ['OS=="android"', {
+          'sources!': [
+            'gcm_client_desktop.cc',
+            'gcm_client_desktop.h',
+          ],
+        }],
       ],
     },
     {
       'target_name': 'gcm_test_support',
       'type': 'static_library',
       'dependencies': [
         'sync_driver',
         '../base/base.gyp:base',
         '../google_apis/gcm/gcm.gyp:gcm',
         '../net/net.gyp:net',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'gcm/fake_gcm_app_handler.cc',
         'gcm/fake_gcm_app_handler.h',
         'gcm/fake_gcm_client.cc',
         'gcm/fake_gcm_client.h',
         'gcm/fake_gcm_client_factory.cc',
         'gcm/fake_gcm_client_factory.h',
       ],
     },
   ],
 }