Reading List: Mark entry read when opening external app.

ios/web/public/web_state/ui/crw_web_delegate.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
 #define IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
 
 #include <stdint.h>
 #import <UIKit/UIKit.h>
 #include <vector>
 
 #import "base/ios/block_types.h"
 #include "ios/web/public/favicon_url.h"
 #import "ios/web/public/navigation_manager.h"
 #include "ios/web/public/ssl_status.h"
 #import "ios/web/public/web_state/ui/crw_native_content.h"
 #import "ios/web/public/web_state/web_state.h"
 #include "ui/base/page_transition_types.h"
 
 class GURL;
 @class CRWWebController;
 
 // Methods implemented by the delegate of the CRWWebController.
 // DEPRECATED, do not conform to this protocol and do not add any methods to it.
 // Use web::WebStateDelegate instead.
 // TODO(crbug.com/674991): Remove this protocol.
 @protocol CRWWebDelegate<NSObject>
 
+// Current navigation triggered an external app so the loading will be
+// cancelled.
+- (void)currentNavigationWillContinueInExternalApp;

[Eugene But (OOO till 7-30), 2017/03/29 15:44:15]

We should really avoid adding new methods to CRWWebDelegate (we working on
removing this protocol). CRWWebDelegate already has 4 methods for launching
external apps, so can we reuse |openExternalURL:linkClicked:| instead of adding
a new one?

[Olivier, 2017/03/29 15:49:45]

|openExternalURL:linkClicked:| is called after [self stopLoading];in the web
controller.

So data on the current navigation is lost (and if the current page is native,
like an ntp, a navigation to chrome://newtab is synchronously triggered).

So to reuse |openExternalURL:linkClicked:|, we should either save and pass the
data of the previous navigation, or move the call to [self stopLoading]; after
the call to  |openExternalURL:linkClicked:|.

If you think one of these changes is safer, I can do it.

+
 // Called when an external app needs to be opened, it also passes |linkClicked|
 // to track if this call was a result of user action or not. Returns YES iff
 // |URL| is launched in an external app.
 - (BOOL)openExternalURL:(const GURL&)URL linkClicked:(BOOL)linkClicked;
 
 // This method is invoked whenever the system believes the URL is about to
 // change, or immediately after any unexpected change of the URL, prior to
 // updating the navigation manager's pending entry.
 // Phase will be LOAD_REQUESTED.
 - (void)webWillAddPendingURL:(const GURL&)url
@@ skipping 62 matching lines @@
 // Called when a PassKit file is downloaded. |data| should be the data from a
 // PassKit file, but this is not guaranteed, and the delegate is responsible for
 // error handling non PassKit data using -[PKPass initWithData:error:]. If the
 // download does not successfully complete, |data| will be nil.
 - (void)webController:(CRWWebController*)webController
     didLoadPassKitObject:(NSData*)data;
 
 @end
 
 #endif  // IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_