Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp

Issue 2784753003: CSP: Enable whitelisting of external JavaScript via hashes (Closed)
Patch Set: remove duplicate test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
diff --git a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
index afbe2531855e8d549ea1314d1e06898d97344f9b..4a391d9c8cc8b357b1268ee0c60e5e96ab71ea88 100644
--- a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
+++ b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
@@ -495,12 +495,14 @@ bool isAllowedByAll(const CSPDirectiveListVector& policies,
template <bool (CSPDirectiveList::*allowFromURLWithNonceAndParser)(
const KURL&,
const String& nonce,
+ const IntegrityMetadataSet& hashes,
ParserDisposition parserDisposition,
RedirectStatus,
SecurityViolationReportingPolicy) const>
bool isAllowedByAll(const CSPDirectiveListVector& policies,
const KURL& url,
const String& nonce,
+ const IntegrityMetadataSet& hashes,
ParserDisposition parserDisposition,
RedirectStatus redirectStatus,
SecurityViolationReportingPolicy reportingPolicy) {
@@ -521,7 +523,7 @@ bool isAllowedByAll(const CSPDirectiveListVector& policies,
bool isAllowed = true;
for (const auto& policy : policies) {
isAllowed &= (policy.get()->*allowFromURLWithNonceAndParser)(
- url, nonce, parserDisposition, redirectStatus, reportingPolicy);
+ url, nonce, hashes, parserDisposition, redirectStatus, reportingPolicy);
}
return isAllowed;
}
@@ -698,6 +700,7 @@ bool ContentSecurityPolicy::allowPluginTypeForDocument(
bool ContentSecurityPolicy::allowScriptFromSource(
const KURL& url,
const String& nonce,
+ const IntegrityMetadataSet& hashes,
ParserDisposition parserDisposition,
RedirectStatus redirectStatus,
SecurityViolationReportingPolicy reportingPolicy) const {
@@ -709,7 +712,7 @@ bool ContentSecurityPolicy::allowScriptFromSource(
: UseCounter::ScriptWithCSPBypassingSchemeNotParserInserted);
}
return isAllowedByAll<&CSPDirectiveList::allowScriptFromSource>(
- m_policies, url, nonce, parserDisposition, redirectStatus,
+ m_policies, url, nonce, hashes, parserDisposition, redirectStatus,
reportingPolicy);
}
@@ -779,8 +782,9 @@ bool ContentSecurityPolicy::allowRequest(
case WebURLRequest::RequestContextImport:
case WebURLRequest::RequestContextScript:
case WebURLRequest::RequestContextXSLT:
- return allowScriptFromSource(url, nonce, parserDisposition,
- redirectStatus, reportingPolicy);
+ return allowScriptFromSource(url, nonce, integrityMetadata,
+ parserDisposition, redirectStatus,
+ reportingPolicy);
case WebURLRequest::RequestContextManifest:
return allowManifestFromSource(url, redirectStatus, reportingPolicy);
case WebURLRequest::RequestContextServiceWorker:
@@ -901,7 +905,8 @@ bool ContentSecurityPolicy::allowWorkerContextFromSource(
m_policies, url, redirectStatus,
SecurityViolationReportingPolicy::SuppressReporting) &&
!isAllowedByAll<&CSPDirectiveList::allowScriptFromSource>(
- m_policies, url, AtomicString(), NotParserInserted, redirectStatus,
+ m_policies, url, AtomicString(), IntegrityMetadataSet(),
+ NotParserInserted, redirectStatus,
SecurityViolationReportingPolicy::SuppressReporting)) {
UseCounter::count(*document,
UseCounter::WorkerAllowedByChildBlockedByScript);

Powered by Google App Engine
This is Rietveld 408576698