Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2784673004: Consider compositing state in row background display item client accessor. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
index eb63f020e358aaf53c69e7e1e47922ef0e0c8edb..e1d9e970e49c2a94e7acba2a0c5f789209a7d60f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
@@ -337,7 +337,8 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
return m_collapsedBorderValues.get();
}
const DisplayItemClient& backgroundDisplayItemClient() const {
- return m_rowBackgroundDisplayItemClient
+ return (m_rowBackgroundDisplayItemClient &&
+ usesCompositedCellDisplayItemClients())
Xianzhu 2017/03/29 00:43:53 How about keeping this as-is and changing ensureIs
Xianzhu 2017/03/29 00:58:55 I read your comment in the bug and now think this
? static_cast<const DisplayItemClient&>(
*m_rowBackgroundDisplayItemClient)
: *this;

Powered by Google App Engine
This is Rietveld 408576698