Add getStatementCompletion to the API spec

Add getStatementCompletion to the API spec

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a2cca3a52d03ddf10e0bc4651faba4b582738d8

[messick, 2017-03-28 22:52:42]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2017-03-29 00:34:54]

We'll also need to increment the version number of the server API (both in the
spec_input.html and in the class AnalysisServer) so that clients can know
whether or not this API is available. It isn't a breaking change, so a minor
version increment is appropriate.

If you think we might want to modify the API after it's committed, then you
might want to wait to commit this until after the last full push for 1.23.
Otherwise changes might be breaking changes.

Other than that, lgtm.

[scheglov, 2017-03-29 01:17:52]

LGTM

[scheglov, 2017-03-29 01:18:34]

https://codereview.chromium.org/2784673003/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/2784673003/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:1836: <ref>int</ref>
bool?

[messick, 2017-03-29 14:24:08]

On 2017/03/29 01:18:34, scheglov wrote:
>
https://codereview.chromium.org/2784673003/diff/1/pkg/analysis_server/tool/sp...
> File pkg/analysis_server/tool/spec/spec_input.html (right):
> 
>
https://codereview.chromium.org/2784673003/diff/1/pkg/analysis_server/tool/sp...
> pkg/analysis_server/tool/spec/spec_input.html:1836: <ref>int</ref>
> bool?

Thanks. Changed.

[messick, 2017-03-29 14:27:25]

On 2017/03/29 00:34:54, Brian Wilkerson wrote:
> We'll also need to increment the version number of the server API (both in the
> spec_input.html and in the class AnalysisServer) so that clients can know
> whether or not this API is available. It isn't a breaking change, so a minor
> version increment is appropriate.
> 
> If you think we might want to modify the API after it's committed, then you
> might want to wait to commit this until after the last full push for 1.23.
> Otherwise changes might be breaking changes.
> 
> Other than that, lgtm.

I'm fine with waiting, I think (I don't remember what the schedule is, though).
However, is a breaking change really going to break anything if none of the
functionality has been implemented?

I changed the version to 1.18.1. I forgot to ask when that was supposed
to happen, and now I know :)

[Brian Wilkerson, 2017-03-29 14:43:46]

> I'm fine with waiting, I think (I don't remember what the schedule is,
though).

I believe the last full push is suppose to happen today, so baring significant
problems that can't be cherry picked to fix, we should be safe later today or
tomorrow.

> However, is a breaking change really going to break anything if none of the
> functionality has been implemented?

I suppose it won't really matter as long as no client code has shipped that
makes use of the new functionality.

I believe in the past we've skirted this issue by adding the HTML attribute
'experimental' to new requests to indicate that it should not be depended on
yet. (I didn't remember that until this morning.) That would be another approach
we could take.

[messick, 2017-03-29 18:01:42]

I bumped the version number, changed 'int' to 'bool' and added the experimental
attribute to the request.

PTAL (especially if the version number should be change now or later, after
experimental is removed)

[Brian Wilkerson, 2017-03-29 18:04:17]

lgtm

In my opinion, there isn't any reason to bump the version number unless you need
to have it bumped in order to make client-side development easier.

[messick, 2017-03-30 17:13:34]

Description was changed from

==========
Add getStatementCompletion to the API spec
==========

to

==========
Add getStatementCompletion to the API spec

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a2cca3a52d03ddf10e0bc4651faba4b582738d8
==========

[messick, 2017-03-30 17:13:36]

Committed patchset #2 (id:20001) manually as
4a2cca3a52d03ddf10e0bc4651faba4b582738d8 (presubmit successful).