chrome/browser/resources/cleanup_tool/icons.html - Issue 2784653004: Cleanup Tool WebUI: Add HTML content and styling with dummy JS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/cleanup_tool/icons.html

Issue 2784653004: Cleanup Tool WebUI: Add HTML content and styling with dummy JS (Closed)

Patch Set: Port in review changes on now-deleted main.html to cleanup.html Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/cleanup_tool/compiled_resources2.gyp ('k') | chrome/browser/resources/cleanup_tool/main.html » ('j') | chrome/browser/resources/cleanup_tool/manager.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html">

	3

	4 <iron-iconset-svg size="24" name="cleanup">

	5 <svg>

	6 <defs>

	7 <!--

	8 This icon is not from Polymer's iron-icons; it was manually edited to put

	9 an exclamation mark inside of a shield.

	10 -->

	11 <g id="infected-user"><path d="M12 1L3 5v6c0 5.55 3.84 10.74 9 12 5.16-1.2 6 9-6.45 9-12V5l-9-4zm1 12h-2V6h2v6zm0 4h-2v-2h2v2z"></path></g>

	12 <!--

	13 These icons are copied from Polymer's iron-icons and kept in sorted order.

	14 See http://goo.gl/Y1OdAq for instructions on adding additional icons.

	15 -->

	16 <g id="verified-user"><path d="M12 1L3 5v6c0 5.55 3.84 10.74 9 12 5.16-1.2 6 9-6.45 9-12V5l-9-4zm-2 16l-4-4 1.41-1.41L10 14.17l6.59-6.59L18 9l-8 8z"></path ></g>
	ftirelo 2017/03/29 20:59:11 Maybe rename this to "clean-user" to be consistent Maybe rename this to "clean-user" to be consistent with class "clean-icon"? If you prefer to use a different name, please rename the class as well for consistency. proberge 2017/03/29 21:29:36 The icon is named verified-user in https://www.web Show quoted text On 2017/03/29 20:59:11, ftirelo wrote: > Maybe rename this to "clean-user" to be consistent with class "clean-icon"? If > you prefer to use a different name, please rename the class as well for > consistency. The icon is named verified-user in https://www.webcomponents.org/element/PolymerElements/iron-icons/demo/demo/in.... Keeping the same name is probably desired (but not explicitly stated by http://dev.chromium.org/developers/updating-webui-for-material-design/using-p...). Not sure about updating the CSS name. Clean and verified don't mean the same thing and I'd rather have an inconsistency than a misleading name.
	17 </defs>

	18 </svg>

	19 </iron-iconset-svg>

OLD	NEW