chrome/browser/resources/cleanup_tool/toolbar.html - Issue 2784653004: Cleanup Tool WebUI: Add HTML content and styling with dummy JS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/cleanup_tool/toolbar.html

Issue 2784653004: Cleanup Tool WebUI: Add HTML content and styling with dummy JS (Closed)

Patch Set: Fix broken i18n commands Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/cleanup_tool/cleanup.html ('K') | « chrome/browser/resources/cleanup_tool/main.html ('k') | chrome/browser/resources/cleanup_tool/toolbar.js » ('j') | chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/assert.html">

	2 <link rel="import" href="chrome://resources/html/cr.html">

	3 <link rel="import" href="chrome://resources/html/polymer.html">

	4

	5 <dom-module id="cleanup-tool-toolbar">

	6 <template>

	7 <style>

	8 :host {

	9 align-items: center;

	10 background: var(--md-toolbar-color);

	11 color: white;

	12 display: flex;

	13 min-height: 56px;

	14 }

	15

	16 #page-title {

	17 font-size: 16px;
	Dan Beam 2017/04/04 00:00:00 can you use %, em, or rem instead of px for font-s can you use %, em, or rem instead of px for font-size? this would allow the page to respect the user's default font sizes from settings proberge 2017/04/04 16:10:04 Done. Show quoted text On 2017/04/04 00:00:00, Dan Beam (slow) wrote: > can you use %, em, or rem instead of px for font-size? this would allow the > page to respect the user's default font sizes from settings Done.
	18 overflow: hidden;

	19 padding-left: 18px;
	Dan Beam 2017/04/04 00:00:00 -left doesn't work in RTL, can you use -webkit-pad -left doesn't work in RTL, can you use -webkit-padding-start? proberge 2017/04/04 16:10:03 Good catch, thanks! Show quoted text On 2017/04/04 00:00:00, Dan Beam (slow) wrote: > -left doesn't work in RTL, can you use -webkit-padding-start? Good catch, thanks!
	20 white-space: nowrap;

	21 }

	22 </style>

	23 <div id="page-title" i18n-content="title"></div>
	Dan Beam 2017/04/04 00:00:00 can you just use <div id="page-title">$i18n{title} can you just use <div id="page-title">$i18n{title}</div> instead of i18n-content? this would allow you to remove the i18n_template.js proberge 2017/04/04 16:10:06 Done. Show quoted text On 2017/04/04 00:00:00, Dan Beam (slow) wrote: > can you just use <div id="page-title">$i18n{title}</div> instead of > i18n-content? this would allow you to remove the i18n_template.js Done.
	24 </template>

	25 <script src="chrome://cleanup/toolbar.js"></script>

	26 </dom-module>

OLD	NEW