chrome/browser/resources/cleanup_tool/cleanup.html - Issue 2784653004: Cleanup Tool WebUI: Add HTML content and styling with dummy JS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/cleanup_tool/cleanup.html

Issue 2784653004: Cleanup Tool WebUI: Add HTML content and styling with dummy JS (Closed)

Patch Set: Fix broken i18n commands Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/cleanup_tool/compiled_resources2.gyp » ('j') | chrome/browser/resources/cleanup_tool/toolbar.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html dir="$i18n{textdirection}" lang="$i18n{language}">

	3 <head>

	4 <meta name="google" value="notranslate">

	5 <meta charset="utf-8">

	6 <title>$i18n{title}</title>

	7 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

	8 <link rel="stylesheet" href="chrome://resources/css/md_colors.css">

	9 <script src="chrome://resources/js/load_time_data.js"></script>
	Dan Beam 2017/04/04 00:00:00 can you import load_time_data.html instead? can you import load_time_data.html instead? proberge 2017/04/04 16:10:02 Done. Show quoted text On 2017/04/04 00:00:00, Dan Beam (slow) wrote: > can you import load_time_data.html instead? Done.
	10 <script src="strings.js"></script>
	Dan Beam 2017/04/04 00:00:00 can you put these scripts at the bottom of the pag can you put these scripts at the bottom of the page? proberge 2017/04/04 16:10:02 Done. Show quoted text On 2017/04/04 00:00:00, Dan Beam (slow) wrote: > can you put these scripts at the bottom of the page? Done.
	11

	12 <style>

	13 html {

	14 background: var(--md-background-color);

	15 }

	16

	17 body {

	18 margin: 0;

	19 }

	20

	21 :root {

	22 --cleanup-card-margin: 25px;

	23 --cleanup-card-width: 800px;

	24 }

	25 </style>

	26 </head>

	27

	28 <body>

	29 <cleanup-tool-toolbar></cleanup-tool-toolbar>

	30 <cleanup-manager></cleanup-manager>

	31 <link rel="import" href="chrome://resources/html/cr.html">

	32 <link rel="import" href="chrome://resources/html/polymer.html">

	33 <link rel="import" href="chrome://cleanup/toolbar.html">

	34 </body>

	35

	36 <script src="chrome://resources/js/i18n_template.js"></script>
	Dan Beam 2017/04/04 00:00:00 indent off why are you using i18n_template.js? indent off why are you using i18n_template.js? proberge 2017/04/04 16:10:02 It was needed when I was using i18n-content in too Show quoted text On 2017/04/04 00:00:00, Dan Beam (slow) wrote: > indent off > > why are you using i18n_template.js? It was needed when I was using i18n-content in toolbar.html. Removed it.
	37 </html>

OLD	NEW