Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: media/audio/audio_output_delegate.h

Issue 2784563003: WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction (Closed)
Patch Set: nitfixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_delegate.h
diff --git a/media/audio/audio_output_delegate.h b/media/audio/audio_output_delegate.h
index 0d9c540b045d2afd02d9135341ab549b14b83c18..9d25df9e90eeb9434196894f7d6c32a91d2c20d5 100644
--- a/media/audio/audio_output_delegate.h
+++ b/media/audio/audio_output_delegate.h
@@ -43,14 +43,6 @@ class MEDIA_EXPORT AudioOutputDelegate {
AudioOutputDelegate();
virtual ~AudioOutputDelegate();
- // TODO(maxmorin): Remove GetController() when crbug.com/647185 is closed.
- // This function is used to provide control of the audio stream to
- // WebrtcAudioPrivateGetActiveSinkFunction and others in the webrtc extension
- // API. Since the controller is shared, this means that it might outlive the
- // AudioOutputDelegate. In this case, it is still safe to call functions on
- // the controller, but it will not do anything. The controller is also shared
- // with AudioStreamMonitor.
- virtual scoped_refptr<AudioOutputController> GetController() const = 0;
virtual int GetStreamId() const = 0;
// Stream control:

Powered by Google App Engine
This is Rietveld 408576698