chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h - Issue 2784533002: Turn on auto-dismissing dialogs for trunk builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2784533002: Turn on auto-dismissing dialogs for trunk builds. (Closed)

Patch Set: fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

index 1417cd780aa9759bd9798ef3321d93b47a173153..e000e7dd520e42ac92a59e1ba0eb31368b5f3b85 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

@@ -37,6 +37,7 @@ class JavaScriptDialogTabHelper

~JavaScriptDialogTabHelper() override;

void SetDialogShownCallbackForTesting(base::Closure callback);

+ bool IsShowingDialogForTesting();

Devlin 2017/05/01 17:12:22 drive-by nit: bool IsShowingDialogForTesting() con

Avi (use Gerrit) 2017/05/01 18:55:23 Done.

// JavaScriptDialogManager:

void RunJavaScriptDialog(content::WebContents* web_contents,

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »