Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: components/prefs/pref_service_unittest.cc

Issue 2784513002: Move PrefRegistrySimple to use unique_ptr<Value> (Closed)
Patch Set: Android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/pref_registry_simple.cc ('k') | components/proxy_config/pref_proxy_config_tracker_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/pref_service_unittest.cc
diff --git a/components/prefs/pref_service_unittest.cc b/components/prefs/pref_service_unittest.cc
index 17bfda30640375b15071f2873580e0b33a9c2994..b64ddad95f3a75c909721a19bbf7e3a40ca462a2 100644
--- a/components/prefs/pref_service_unittest.cc
+++ b/components/prefs/pref_service_unittest.cc
@@ -315,8 +315,9 @@ TEST(PrefServiceTest, WriteablePrefStoreFlags) {
for (size_t i = 0; i < arraysize(kRegistrationToWriteFlags); ++i) {
RegistrationToWriteFlags entry = kRegistrationToWriteFlags[i];
- registry->RegisterDictionaryPref(
- entry.pref_name, new base::DictionaryValue(), entry.registration_flags);
+ registry->RegisterDictionaryPref(entry.pref_name,
+ base::MakeUnique<base::DictionaryValue>(),
+ entry.registration_flags);
SCOPED_TRACE("Currently testing pref with name: " +
std::string(entry.pref_name));
« no previous file with comments | « components/prefs/pref_registry_simple.cc ('k') | components/proxy_config/pref_proxy_config_tracker_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698