Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

Issue 2784493002: Stop appending fragmentainer groups when flow thread offset approaches infinity. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/doubly-nested-with-insane-child-height-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
index c46732561903aa25bcb3343649e360bd5bf7a7e3..1f7f5a587362c7f48ddbff40d8c8edce312bb0ab 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
@@ -258,6 +258,11 @@ bool LayoutMultiColumnSet::needsNewFragmentainerGroupAt(
if (!multiColumnFlowThread()->enclosingFragmentationContext())
return false;
+ // If we have reached the limits of what a LayoutUnit can hold, we better
+ // stop, or we'd end up with zero-height columns.
+ if (offsetInFlowThread.mightBeSaturated())
+ return false;
+
// We're in a nested fragmentation context, and the last fragmentainer group
// cannot hold content at the specified offset without overflowing. This
// usually warrants a new fragmentainer group; however, this will not be the
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/doubly-nested-with-insane-child-height-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698