Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2784473002: [Bindings] Move some private symbols from V8HiddenValue to V8PrivateProperty (Closed)
Patch Set: Work for comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8PrivateProperty_h 5 #ifndef V8PrivateProperty_h
6 #define V8PrivateProperty_h 6 #define V8PrivateProperty_h
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "bindings/core/v8/ScriptPromiseProperties.h" 10 #include "bindings/core/v8/ScriptPromiseProperties.h"
(...skipping 16 matching lines...) Expand all
27 X(CustomElement, AttributeChangedCallback) \ 27 X(CustomElement, AttributeChangedCallback) \
28 X(CustomElement, ConnectedCallback) \ 28 X(CustomElement, ConnectedCallback) \
29 X(CustomElement, DisconnectedCallback) \ 29 X(CustomElement, DisconnectedCallback) \
30 X(CustomElement, Document) \ 30 X(CustomElement, Document) \
31 X(CustomElement, IsInterfacePrototypeObject) \ 31 X(CustomElement, IsInterfacePrototypeObject) \
32 X(CustomElement, NamespaceURI) \ 32 X(CustomElement, NamespaceURI) \
33 X(CustomElement, TagName) \ 33 X(CustomElement, TagName) \
34 X(CustomElement, Type) \ 34 X(CustomElement, Type) \
35 X(DOMException, Error) \ 35 X(DOMException, Error) \
36 X(ErrorEvent, Error) \ 36 X(ErrorEvent, Error) \
37 X(Global, Event) \
37 X(IDBObserver, Callback) \ 38 X(IDBObserver, Callback) \
38 X(IntersectionObserver, Callback) \ 39 X(IntersectionObserver, Callback) \
40 X(MessageChannel, Port1) \
41 X(MessageChannel, Port2) \
39 X(MessageEvent, CachedData) \ 42 X(MessageEvent, CachedData) \
40 X(MutationObserver, Callback) \ 43 X(MutationObserver, Callback) \
41 X(NamedConstructor, Initialized) \ 44 X(NamedConstructor, Initialized) \
42 X(PerformanceObserver, Callback) \ 45 X(PerformanceObserver, Callback) \
43 X(SameObject, NotificationActions) \ 46 X(SameObject, NotificationActions) \
44 X(SameObject, NotificationData) \ 47 X(SameObject, NotificationData) \
45 X(SameObject, NotificationVibrate) \ 48 X(SameObject, NotificationVibrate) \
46 X(SameObject, PerformanceLongTaskTimingAttribution) \ 49 X(SameObject, PerformanceLongTaskTimingAttribution) \
50 X(PopStateEvent, State) \
Yuki 2017/03/29 06:22:53 nit: sort in alphabetical order?
peria 2017/03/29 07:00:01 Done.
47 X(V8NodeFilterCondition, Filter) \ 51 X(V8NodeFilterCondition, Filter) \
48 X(Window, DocumentCachedAccessor) 52 X(Window, DocumentCachedAccessor)
49 53
50 // The getter's name for a private property. 54 // The getter's name for a private property.
51 #define V8_PRIVATE_PROPERTY_GETTER_NAME(InterfaceName, PrivateKeyName) \ 55 #define V8_PRIVATE_PROPERTY_GETTER_NAME(InterfaceName, PrivateKeyName) \
52 get##InterfaceName##PrivateKeyName 56 get##InterfaceName##PrivateKeyName
53 57
54 // The member variable's name for a private property. 58 // The member variable's name for a private property.
55 #define V8_PRIVATE_PROPERTY_MEMBER_NAME(InterfaceName, PrivateKeyName) \ 59 #define V8_PRIVATE_PROPERTY_MEMBER_NAME(InterfaceName, PrivateKeyName) \
56 m_symbol##InterfaceName##PrivateKeyName 60 m_symbol##InterfaceName##PrivateKeyName
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 #define V8_PRIVATE_PROPERTY_DECLARE_MEMBER(InterfaceName, KeyName) \ 178 #define V8_PRIVATE_PROPERTY_DECLARE_MEMBER(InterfaceName, KeyName) \
175 v8::Eternal<v8::Private> V8_PRIVATE_PROPERTY_MEMBER_NAME( \ 179 v8::Eternal<v8::Private> V8_PRIVATE_PROPERTY_MEMBER_NAME( \
176 InterfaceName, KeyName); // NOLINT(readability/naming/underscores) 180 InterfaceName, KeyName); // NOLINT(readability/naming/underscores)
177 V8_PRIVATE_PROPERTY_FOR_EACH(V8_PRIVATE_PROPERTY_DECLARE_MEMBER) 181 V8_PRIVATE_PROPERTY_FOR_EACH(V8_PRIVATE_PROPERTY_DECLARE_MEMBER)
178 #undef V8_PRIVATE_PROPERTY_DECLARE_MEMBER 182 #undef V8_PRIVATE_PROPERTY_DECLARE_MEMBER
179 }; 183 };
180 184
181 } // namespace blink 185 } // namespace blink
182 186
183 #endif // V8PrivateProperty_h 187 #endif // V8PrivateProperty_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698