chromecast/browser/cast_content_browser_client.h - Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/cast_content_browser_client.h

Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted. (Closed)

Patch Set: addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/cast_content_browser_client.h

diff --git a/chromecast/browser/cast_content_browser_client.h b/chromecast/browser/cast_content_browser_client.h

index 4bf181e51cebe24dcd1c76ad572f551c04337081..cfa48928924e5548801c973905186836500caed2 100644

--- a/chromecast/browser/cast_content_browser_client.h

+++ b/chromecast/browser/cast_content_browser_client.h

@@ -100,7 +100,7 @@ class CastContentBrowserClient : public content::ContentBrowserClient {

media::MediaPipelineBackendManager* media_pipeline_backend_manager();

- ::media::ScopedAudioManagerPtr CreateAudioManager(

+ std::unique_ptr<::media::AudioManager> CreateAudioManager(

::media::AudioLogFactory* audio_log_factory) override;

std::unique_ptr<::media::CdmFactory> CreateCdmFactory() override;

#endif // BUILDFLAG(IS_CAST_USING_CMA_BACKEND)