Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: media/audio/cras/audio_manager_cras.cc

Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted. (Closed)
Patch Set: cleanup Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/cras/audio_manager_cras.cc
diff --git a/media/audio/cras/audio_manager_cras.cc b/media/audio/cras/audio_manager_cras.cc
index a1d059e5ed91a60f43e365c800b32f247a8dfd68..875904a816c940df2b71e1eeac3f067044e71f27 100644
--- a/media/audio/cras/audio_manager_cras.cc
+++ b/media/audio/cras/audio_manager_cras.cc
@@ -134,21 +134,15 @@ bool AudioManagerCras::HasAudioInputDevices() {
return false;
}
-AudioManagerCras::AudioManagerCras(
- scoped_refptr<base::SingleThreadTaskRunner> task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
- AudioLogFactory* audio_log_factory)
- : AudioManagerBase(std::move(task_runner),
- std::move(worker_task_runner),
- audio_log_factory),
+AudioManagerCras::AudioManagerCras(std::unique_ptr<AudioThread> audio_thread,
+ AudioLogFactory* audio_log_factory)
+ : AudioManagerBase(std::move(audio_thread), audio_log_factory),
beamforming_on_device_id_(nullptr),
beamforming_off_device_id_(nullptr) {
SetMaxOutputStreamsAllowed(kMaxOutputStreams);
}
-AudioManagerCras::~AudioManagerCras() {
- Shutdown();
-}
+AudioManagerCras::~AudioManagerCras() = default;
void AudioManagerCras::ShowAudioInputSettings() {
NOTIMPLEMENTED();

Powered by Google App Engine
This is Rietveld 408576698