Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2451)

Unified Diff: content/content_tests.gypi

Issue 278443003: Android: cleanup gtest_target_type conditions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gyp ('k') | gpu/gpu.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_tests.gypi
diff --git a/content/content_tests.gypi b/content/content_tests.gypi
index 090095941879089fed370f759aad1fdc2b7ae518..2dd9aa556c80ee8c69b9ef70e2dc22e6673ca7c2 100644
--- a/content/content_tests.gypi
+++ b/content/content_tests.gypi
@@ -878,7 +878,7 @@
'../third_party/libvpx/libvpx.gyp:libvpx',
],
}],
- ['OS == "android" and gtest_target_type == "shared_library"', {
+ ['OS == "android"', {
'dependencies': [
'../testing/android/native_test.gyp:native_test_native_code',
],
@@ -952,7 +952,7 @@
'test/run_all_perftests.cc',
],
'conditions': [
- ['OS == "android" and gtest_target_type == "shared_library"', {
+ ['OS == "android"', {
'dependencies': [
'../testing/android/native_test.gyp:native_test_native_code',
],
@@ -1281,7 +1281,7 @@
'sources!': [
# These tests depend on single process mode, which is disabled
# in official builds.
- 'renderer/browser_render_view_browsertest.cc',
+ 'renderer/browser_render_view_browsertest.cc',
'renderer/dom_serializer_browsertest.cc',
'renderer/resource_fetcher_browsertest.cc',
'renderer/savable_resources_browsertest.cc',
@@ -1490,10 +1490,7 @@
},
]
}],
- # Special target to wrap a gtest_target_type==shared_library
- # content_unittests into an android apk for execution.
- # See base.gyp for TODO(jrg)s about this strategy.
- ['OS == "android" and gtest_target_type == "shared_library"', {
+ ['OS == "android"', {
'targets': [
{
'target_name': 'content_gl_tests_apk',
« no previous file with comments | « components/components_tests.gyp ('k') | gpu/gpu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698