Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: base/base.gyp

Issue 278443003: Android: cleanup gtest_target_type conditions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/apk_test.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index c56fb88b125f13a042bcb512b08ce730bdf0856d..945ef9d67a014479e27e44f8c85d2032222c4e63 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -663,13 +663,7 @@
['OS == "android"', {
'dependencies': [
'android/jni_generator/jni_generator.gyp:jni_generator_tests',
- ],
- 'conditions': [
- ['gtest_target_type == "shared_library"', {
- 'dependencies': [
- '../testing/android/native_test.gyp:native_test_native_code',
- ],
- }],
+ '../testing/android/native_test.gyp:native_test_native_code',
],
}],
['OS == "ios" and _toolset != "host"', {
@@ -805,7 +799,7 @@
'../testing/perf/perf_test.cc'
],
'conditions': [
- ['OS == "android" and gtest_target_type == "shared_library"', {
+ ['OS == "android"', {
'dependencies': [
'../testing/android/native_test.gyp:native_test_native_code',
],
@@ -1432,7 +1426,7 @@
],
}],
- ['OS == "android" and gtest_target_type == "shared_library"', {
+ ['OS == "android"', {
'targets': [
{
'target_name': 'base_perftests_apk',
@@ -1463,13 +1457,7 @@
},
],
}],
- # Special target to wrap a gtest_target_type == shared_library
- # base_unittests into an android apk for execution.
- # TODO(jrg): lib.target comes from _InstallableTargetInstallPath()
- # in the gyp make generator. What is the correct way to extract
- # this path from gyp and into 'raw' for input to antfiles?
- # Hard-coding in the gypfile seems a poor choice.
- ['OS == "android" and gtest_target_type == "shared_library"', {
+ ['OS == "android"', {
'targets': [
{
'target_name': 'base_unittests_apk',
« no previous file with comments | « no previous file | build/apk_test.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698