Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html

Issue 2784413003: DevTools: carefully cleanup javascript sourcemaps (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html b/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
index 2b33d6befefb69efe8320d3d216127e7a6ac8d65..b5a6db9c06ddcae64a791983fa5f306b7c709c4e 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
@@ -137,10 +137,12 @@ function test()
{
InspectorTest.addResult("Adding compiled.js");
InspectorTest.evaluateInPage("\n//# sourceMappingURL=http://127.0.0.1:8000/inspector/resources/source-map.json_\n");
- InspectorTest.addSniffer(Bindings.CompilerScriptMapping.prototype, "_sourceMapLoaded", onSourceMapLoaded);
+ InspectorTest.debuggerModel.sourceMapManager().addEventListener(
+ SDK.SourceMapManager.Events.SourceMapFailedToAttach, onSourceMapLoaded, this);
- function onSourceMapLoaded(script, uiSourceCodePath, sourceMap)
+ function onSourceMapLoaded(event)
{
+ var script = event.data;
if (script.sourceMapURL !== "http://127.0.0.1:8000/inspector/resources/source-map.json_")
return;
InspectorTest.addResult("SourceMap Failed to load.");

Powered by Google App Engine
This is Rietveld 408576698