Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2784363002: flag to enable fasta scanner in analyzer (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -9 lines) Patch
M pkg/analyzer/lib/src/dart/scanner/reader.dart View 3 chunks +10 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 3 chunks +124 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/dependency_grapher_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/scanner/reader.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/scanner_roundtrip_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/scanner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/src/base/libraries_reader_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/tool/perf.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 8 months ago (2017-03-30 16:29:22 UTC) #2
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-03-30 16:39:46 UTC) #3
danrubel
3 years, 8 months ago (2017-03-30 18:16:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c22c6bad6c85a9de8193d8a31e8ab8dacca9aa4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698