Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 278433007: Oilpan: Update a comment for the WTF_ANNOTATE_LEAKING_OBJECT_PTR macro in PageMemory (Closed)

Created:
6 years, 7 months ago by haraken
Modified:
6 years, 7 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Oilpan: Update a comment for the WTF_ANNOTATE_LEAKING_OBJECT_PTR macro in PageMemory This is a follow-up CL for r173508. BUG=369429 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173632

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/platform/heap/Heap.cpp View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
earthdok: PTAL
6 years, 7 months ago (2014-05-08 01:59:22 UTC) #1
kouhei (in TOK)
lgtm
6 years, 7 months ago (2014-05-08 02:04:25 UTC) #2
kouhei (in TOK)
lgtm lgtm
6 years, 7 months ago (2014-05-08 02:04:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/278433007/1
6 years, 7 months ago (2014-05-08 02:05:31 UTC) #4
haraken
The CQ bit was unchecked by haraken@chromium.org
6 years, 7 months ago (2014-05-08 02:23:30 UTC) #5
haraken
Waiting for an approval from earthdok.
6 years, 7 months ago (2014-05-08 02:24:34 UTC) #6
earthdok
lgtm https://codereview.chromium.org/278433007/diff/1/Source/platform/heap/Heap.cpp File Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/278433007/diff/1/Source/platform/heap/Heap.cpp#newcode280 Source/platform/heap/Heap.cpp:280: // This annotation is for letting the Leak ...
6 years, 7 months ago (2014-05-08 09:32:15 UTC) #7
haraken
https://codereview.chromium.org/278433007/diff/1/Source/platform/heap/Heap.cpp File Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/278433007/diff/1/Source/platform/heap/Heap.cpp#newcode280 Source/platform/heap/Heap.cpp:280: // This annotation is for letting the Leak Sanitizer ...
6 years, 7 months ago (2014-05-08 10:38:36 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 7 months ago (2014-05-08 10:38:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/278433007/40001
6 years, 7 months ago (2014-05-08 10:39:27 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 10:39:52 UTC) #11
Message was sent while issue was closed.
Change committed as 173632

Powered by Google App Engine
This is Rietveld 408576698