Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/resources/chromeos/echo/manifest.json

Issue 278433005: Add more background js file and edit access to Google Analytics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/echo/manifest.json
diff --git a/chrome/browser/resources/chromeos/echo/manifest.json b/chrome/browser/resources/chromeos/echo/manifest.json
index a9f1a38447fccb5c2a96b97cd5be02f86bc20c59..d784e23095d05cf07c1cbd8fb7885df27e6c3163 100644
--- a/chrome/browser/resources/chromeos/echo/manifest.json
+++ b/chrome/browser/resources/chromeos/echo/manifest.json
@@ -5,7 +5,7 @@
"version": "1.0.0",
"description": "Chrome Goodies",
"manifest_version": 2,
- "content_security_policy": "default-src 'self'; connect-src 'self' https://chromeos-registration.googleapis.com; script-src 'self' https://ssl.google-analytics.com",
+ "content_security_policy": "default-src 'self'; connect-src 'self' https://chromeos-registration.googleapis.com https://www.google-analytics.com",
"permissions": [
"alarms",
"cookies",
@@ -13,6 +13,7 @@
"echoPrivate",
"metricsPrivate",
"notifications",
+ "storage",
"https://*/*"
],
"icons": {
@@ -27,7 +28,12 @@
"not-eligible.html"
],
"background": {
- "scripts": ["main.js"],
+ "scripts": [
+ "constants.js",
+ "lib/google-analytics-bundle.js",
gauravsh 2014/05/07 23:45:54 I think we should get this reviewed by someone who
davidyu 2014/05/08 05:43:16 +cnwan, who is in charge of this.
+ "analytics.js",
gauravsh 2014/05/07 23:45:54 alpha order?
andycai1 2014/05/08 00:26:43 I think the order matters, the bundle.js needs to
+ "main.js"
+ ],
"persistent": false
},
"externally_connectable": {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698