Add more background js file and edit access to Google Analytics.

Add more background js file and edit access to Google Analytics.

BUG=chromium:369679
BUG=chromium:368815
TEST=Tested manually on daisy

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269908

[andycai1, 2014-05-07 20:33:05]

Please check https://github.com/GoogleChrome/chrome-platform-analytics/wiki for
more info about manifest change for Google Analytics.

[oscarpan, 2014-05-07 20:47:18]

I'd suggest you have it reviewed by someone with more experience. After all you
have to do that since i have no readability and can't approve the cl. If that
takes long, then i think you'd better break down this cl so that it won't block
the bug fix caused by constant.js not being loaded.

[andycai1, 2014-05-07 20:56:08]

Hi Gaurav,

I edited the access to Google Analytics as in helper app:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

I added several js files in the extension. These files are added as background
javascript script in manifest.

Thanks,

Andy

[gauravsh, 2014-05-07 23:45:53]

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/echo/manifest.json (right):

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/echo/manifest.json:33:
"lib/google-analytics-bundle.js",
I think we should get this reviewed by someone who knows about the
google-analytics-bundle.js library. Andy tells me it's used by the Genius App as
well.

+davidyu, cylee

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/echo/manifest.json:34: "analytics.js",
alpha order?

[andycai1, 2014-05-07 23:46:56]

Please see https://chrome-internal-review.googlesource.com/#/c/162485/ for
corresponding extension change

[andycai1, 2014-05-08 00:26:42]

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/echo/manifest.json (right):

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/echo/manifest.json:34: "analytics.js",
On 2014/05/07 23:45:54, gauravsh wrote:
> alpha order?

I think the order matters, the bundle.js needs to be loaded before analytics.js.
I tested that ECHO Extension can't be loaded when reorder the js files.

[davidyu, 2014-05-08 05:43:15]

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/echo/manifest.json (right):

https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/echo/manifest.json:33:
"lib/google-analytics-bundle.js",
On 2014/05/07 23:45:54, gauravsh wrote:
> I think we should get this reviewed by someone who knows about the
> google-analytics-bundle.js library. Andy tells me it's used by the Genius App
as
> well.
> 
> +davidyu, cylee

+cnwan, who is in charge of this.

[andycai1, 2014-05-08 21:40:07]

Please take a look.
The branch date is tomorrow Pacific Time.
Thanks,

Andy

On 2014/05/08 05:43:15, davidyu wrote:
>
https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/echo/manifest.json (right):
> 
>
https://codereview.chromium.org/278433005/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/echo/manifest.json:33:
> "lib/google-analytics-bundle.js",
> On 2014/05/07 23:45:54, gauravsh wrote:
> > I think we should get this reviewed by someone who knows about the
> > google-analytics-bundle.js library. Andy tells me it's used by the Genius
App
> as
> > well.
> > 
> > +davidyu, cylee
> 
> +cnwan, who is in charge of this.

[Jorge Lucangeli Obes, 2014-05-09 17:15:34]

cnwan1 should chime in about lib/google-analytics-bundle.js. From a security
perspective there's not a big difference from script-src to injecting it
directly.

[cnwan, 2014-05-12 08:28:08]

lgtm

The only changes needed to use Chrome Apps Analytics are on in this CL:

1. the compiled JavaScript binary from
https://developer.chrome.com/apps/analytics.

2. and the permission to connect to https://www.google-analytics.com

[Chi-Ngai Wan, 2014-05-12 08:29:09]

Done


On Sat, May 10, 2014 at 1:15 AM, <jorgelo@chromium.org> wrote:

> cnwan1 should chime in about lib/google-analytics-bundle.js. From a
> security
> perspective there's not a big difference from script-src to injecting it
> directly.
>
> https://codereview.chromium.org/278433005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[gauravsh, 2014-05-12 17:14:38]

lgtm

[andycai1, 2014-05-12 18:28:25]

The CQ bit was checked by andycai@chromium.org

[commit-bot: I haz the power, 2014-05-12 18:28:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andycai@chromium.org/278433005/40001

[commit-bot: I haz the power, 2014-05-12 23:22:33]

Change committed as 269908