MD Settings: Second try at fixing ResetSettingsHandler crash

chrome/browser/ui/webui/settings/reset_settings_handler.cc

Index: chrome/browser/ui/webui/settings/reset_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/reset_settings_handler.cc b/chrome/browser/ui/webui/settings/reset_settings_handler.cc
index a41fbae677337d9c0495d3119716ea4e1e546995..7027fd62a4253a153074359e27a67baf5b081ff3 100644
--- a/chrome/browser/ui/webui/settings/reset_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/reset_settings_handler.cc
@@ -145,9 +145,9 @@ void ResetSettingsHandler::HandleResetProfileSettings(
   DCHECK(brandcode_.empty() || config_fetcher_);
   if (config_fetcher_ && config_fetcher_->IsActive()) {
     // Reset once the prefs are fetched.
-    config_fetcher_->SetCallback(base::Bind(
-        &ResetSettingsHandler::ResetProfile, weak_ptr_factory_.GetWeakPtr(),
-        callback_id, send_settings, request_origin));
+    config_fetcher_->SetCallback(base::Bind(&ResetSettingsHandler::ResetProfile,

[tommycli, 2017/03/30 15:26:26]

This just reverts the previous unsuccessful fix.

+                                            base::Unretained(this), callback_id,
+                                            send_settings, request_origin));
   } else {
     ResetProfile(callback_id, send_settings, request_origin);
   }
@@ -228,7 +228,7 @@ void ResetSettingsHandler::OnSettingsFetched() {
 }
 
 void ResetSettingsHandler::ResetProfile(
-    const std::string& callback_id,
+    const std::string callback_id,
     bool send_settings,
     reset_report::ChromeResetReport::ResetRequestOrigin request_origin) {
   DCHECK(!GetResetter()->IsActive());