MD Settings: Second try at fixing ResetSettingsHandler crash

chrome/browser/ui/webui/settings/reset_settings_handler.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 64 matching lines @@
   void OnHideResetProfileBanner(const base::ListValue* args);
 
   // Retrieve the triggered reset tool name, called from Javascript.
   void HandleGetTriggeredResetToolName(const base::ListValue* args);
 
   // Called when BrandcodeConfigFetcher completed fetching settings.
   void OnSettingsFetched();
 
   // Resets profile settings to default values. |send_settings| is true if user
   // gave their consent to upload broken settings to Google for analysis.
+  // |callback_id| must be passed by value, as ResetProfile can destroy its
+  // calling callback, which can clobber const-ref parameters.
   void ResetProfile(
-      const std::string& callback_id,
+      const std::string callback_id,
       bool send_settings,
       reset_report::ChromeResetReport::ResetRequestOrigin request_origin);
 
   // Closes the dialog once all requested settings has been reset.
   void OnResetProfileSettingsDone(
       std::string callback_id,
       bool send_feedback,
       reset_report::ChromeResetReport::ResetRequestOrigin request_origin);
 
 #if defined(OS_CHROMEOS)
@@ skipping 14 matching lines @@
   std::string brandcode_;
 
   base::WeakPtrFactory<ResetSettingsHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ResetSettingsHandler);
 };
 
 }  // namespace settings
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_