Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

Issue 2784313002: Change hittest node to be scrollbar's parent when hittest include a scrollbar (Closed)
Patch Set: bokan and mustaq comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html
diff --git a/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html b/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html
index 0c7081142048e5635007293cf099f9d5628ff7c2..6e5b28b5e0d60cba5e37c81e5eac436601b253ee 100644
--- a/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html
+++ b/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html
@@ -38,11 +38,9 @@
// element under the mouse.
eventSender.mouseUp();
- // TODO(bokan): This is wrong, if the scrollbar captures the input the
- // plugin shouldn't be receiving events. crbug.com/636436.
- shouldBe('eventHistory.length', '2');
- shouldBe('eventHistory[0]', '"plugin.mousedown"');
- shouldBe('eventHistory[1]', '"plugin.mouseup"');
+ // The scrollbar captures the input and the plugin would not receive
bokan 2017/04/04 15:18:01 nit: would -> should
+ // events.
+ shouldBe('eventHistory.length', '0');
requestAnimationFrame(function() {
shouldBeTrue('window.scrollY > 0');
finishJSTest();

Powered by Google App Engine
This is Rietveld 408576698