third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html - Issue 2784313002: Change hittest node to be scrollbar's parent when hittest include a scrollbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

Issue 2784313002: Change hittest node to be scrollbar's parent when hittest include a scrollbar (Closed)

Patch Set: fix tests and add test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture-expected.txt » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

diff --git a/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html b/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

index 0c7081142048e5635007293cf099f9d5628ff7c2..f2ba76b22188236067c4c78b9f458b039face4f6 100644

--- a/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

+++ b/third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

@@ -38,11 +38,9 @@

// element under the mouse.

eventSender.mouseUp();

- // TODO(bokan): This is wrong, if the scrollbar captures the input the

- // plugin shouldn't be receiving events. crbug.com/636436.

- shouldBe('eventHistory.length', '2');

- shouldBe('eventHistory[0]', '"plugin.mousedown"');

- shouldBe('eventHistory[1]', '"plugin.mouseup"');

+ // If the scrollbar captures the input the plugin shouldn't be receiving

mustaq 2017/03/31 16:57:48 This comment is now irrelevant because the bug is

bokan 2017/03/31 20:07:00 Right, we should only have crbug references if the

+ // events. crbug.com/636436.

+ shouldBe('eventHistory.length', '0');

requestAnimationFrame(function() {

shouldBeTrue('window.scrollY > 0');

finishJSTest();