third_party/WebKit/Source/core/layout/HitTestResult.cpp - Issue 2784313002: Change hittest node to be scrollbar's parent when hittest include a scrollbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/HitTestResult.cpp

Issue 2784313002: Change hittest node to be scrollbar's parent when hittest include a scrollbar (Closed)

Patch Set: mustaq comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/HitTestResult.cpp

diff --git a/third_party/WebKit/Source/core/layout/HitTestResult.cpp b/third_party/WebKit/Source/core/layout/HitTestResult.cpp

index ec41d464421cb2290a87b1ff729485ac7090e1ff..23250c7f7b9b79bfdedb91a9cd1f96a5410f0d83 100644

--- a/third_party/WebKit/Source/core/layout/HitTestResult.cpp

+++ b/third_party/WebKit/Source/core/layout/HitTestResult.cpp

@@ -218,7 +218,11 @@ HTMLAreaElement* HitTestResult::imageAreaForImage() const {

void HitTestResult::setInnerNode(Node* n) {

m_innerPossiblyPseudoNode = n;

- if (n && n->isPseudoElement())

+ if (!n) {

+ m_innerNode = n;

+ return;

+ }

+ if (n->isPseudoElement())

n = toPseudoElement(n)->findAssociatedNode();

m_innerNode = n;

if (HTMLAreaElement* area = imageAreaForImage()) {