Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: tools/auto_bisect/bisect_perf_regression_test.py

Issue 2784303004: Bisect - Fix testGetCommitPositionForV8. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 import os 6 import os
7 import re 7 import re
8 import shutil 8 import shutil
9 import sys 9 import sys
10 import urlparse 10 import urlparse
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 458
459 def testGetCommitPosition(self): 459 def testGetCommitPosition(self):
460 cp_git_rev = '7017a81991de983e12ab50dfc071c70e06979531' 460 cp_git_rev = '7017a81991de983e12ab50dfc071c70e06979531'
461 self.assertEqual(291765, source_control.GetCommitPosition(cp_git_rev)) 461 self.assertEqual(291765, source_control.GetCommitPosition(cp_git_rev))
462 462
463 svn_git_rev = 'e6db23a037cad47299a94b155b95eebd1ee61a58' 463 svn_git_rev = 'e6db23a037cad47299a94b155b95eebd1ee61a58'
464 self.assertEqual(291467, source_control.GetCommitPosition(svn_git_rev)) 464 self.assertEqual(291467, source_control.GetCommitPosition(svn_git_rev))
465 465
466 def testGetCommitPositionForV8(self): 466 def testGetCommitPositionForV8(self):
467 bisect_instance = _GetBisectPerformanceMetricsInstance(DEFAULT_OPTIONS) 467 bisect_instance = _GetBisectPerformanceMetricsInstance(DEFAULT_OPTIONS)
468 v8_rev = '21d700eedcdd6570eff22ece724b63a5eefe78cb' 468 v8_rev = '818769db41cb3e83979aa16cc76c69b66045e369'
469 depot_path = os.path.join(bisect_instance.src_cwd, 'v8') 469 depot_path = os.path.join(bisect_instance.src_cwd, 'v8')
470 self.assertEqual( 470 self.assertEqual(
471 23634, source_control.GetCommitPosition(v8_rev, depot_path)) 471 43769, source_control.GetCommitPosition(v8_rev, depot_path))
472 472
473 def testGetCommitPositionForSkia(self): 473 def testGetCommitPositionForSkia(self):
474 bisect_instance = _GetBisectPerformanceMetricsInstance(DEFAULT_OPTIONS) 474 bisect_instance = _GetBisectPerformanceMetricsInstance(DEFAULT_OPTIONS)
475 skia_rev = 'a94d028eCheckAbortsEarly0f2c77f159b3dac95eb90c3b4cf48c61' 475 skia_rev = 'a94d028eCheckAbortsEarly0f2c77f159b3dac95eb90c3b4cf48c61'
476 depot_path = os.path.join(bisect_instance.src_cwd, 'third_party', 'skia') 476 depot_path = os.path.join(bisect_instance.src_cwd, 'third_party', 'skia')
477 # Skia doesn't use commit positions, and GetCommitPosition should 477 # Skia doesn't use commit positions, and GetCommitPosition should
478 # return None for repos that don't use commit positions. 478 # return None for repos that don't use commit positions.
479 self.assertIsNone(source_control.GetCommitPosition(skia_rev, depot_path)) 479 self.assertIsNone(source_control.GetCommitPosition(skia_rev, depot_path))
480 480
481 def testUpdateDepsContent(self): 481 def testUpdateDepsContent(self):
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
750 (None, 0)), 750 (None, 0)),
751 ] 751 ]
752 self._SetupRunGitMock(try_cmd) 752 self._SetupRunGitMock(try_cmd)
753 bisect_perf_regression._StartBuilderTryJob( 753 bisect_perf_regression._StartBuilderTryJob(
754 fetch_build.PERF_BUILDER, git_revision, bot_name, bisect_job_name, 754 fetch_build.PERF_BUILDER, git_revision, bot_name, bisect_job_name,
755 patch) 755 patch)
756 756
757 757
758 if __name__ == '__main__': 758 if __name__ == '__main__':
759 unittest.main() 759 unittest.main()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698