chrome/browser/android/vr_shell/vr_shell_delegate.cc - Issue 2784303002: Adds button to VRShell menu mode, which lets the user manually exit WebVR presentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_shell_delegate.cc

Issue 2784303002: Adds button to VRShell menu mode, which lets the user manually exit WebVR presentation. (Closed)

Patch Set: Fixed closure compiler error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_shell_delegate.cc

diff --git a/chrome/browser/android/vr_shell/vr_shell_delegate.cc b/chrome/browser/android/vr_shell/vr_shell_delegate.cc

index a08b13c74bacdc25ef8809f034901a4aa3e3aff0..5b1945c6cea4e62660b4e6af680b282409109969 100644

--- a/chrome/browser/android/vr_shell/vr_shell_delegate.cc

+++ b/chrome/browser/android/vr_shell/vr_shell_delegate.cc

@@ -164,7 +164,9 @@ void VrShellDelegate::ExitWebVRPresent() {

// VRShell is no longer needed by WebVR, allow it to shut down if it's not

// being used elsewhere.

JNIEnv* env = AttachCurrentThread();

- Java_VrShellDelegate_exitWebVR(env, j_vr_shell_delegate_.obj());

+ if (Java_VrShellDelegate_exitWebVRPresent(env, j_vr_shell_delegate_.obj())) {

+ device_provider_->Device()->OnExitPresent();

+ }

}

void VrShellDelegate::CreateNonPresentingDelegate() {