Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 2784253004: Componentize safe_browsing: decouple threat_details* from the chrome/ layer. (Closed)
Patch Set: fix compile for browser tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
index 02da1be664349984fa0ca676d68215d77d4d9af4..4194cf995b32f0781bc0cb7c89313be2dcece7fb 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
@@ -216,8 +216,11 @@ class TestThreatDetailsFactory : public ThreatDetailsFactory {
ThreatDetails* CreateThreatDetails(
BaseUIManager* delegate,
WebContents* web_contents,
- const security_interstitials::UnsafeResource& unsafe_resource) override {
- details_ = new ThreatDetails(delegate, web_contents, unsafe_resource);
+ const security_interstitials::UnsafeResource& unsafe_resource,
+ net::URLRequestContextGetter* request_context_getter,
+ history::HistoryService* history_service) override {
+ details_ = new ThreatDetails(delegate, web_contents, unsafe_resource,
+ request_context_getter, history_service);
return details_;
}

Powered by Google App Engine
This is Rietveld 408576698