Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2784253003: Use -no_compact_unwind when creating dylibs on Mac. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, ahe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use -no_compact_unwind when creating dylibs on Mac. Instructs the linker not to attempt generating _eh_frame from the DWARF info, avoiding warnings like R=vegorov@google.com ld: warning: could not create compact unwind for _kDartVmSnapshotInstructions: register saved more than once (might be shrink wrap) Committed: https://github.com/dart-lang/sdk/commit/21e9a4fc650bb77ac5b28614f7e28c57a1cbc926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 8 months ago (2017-03-30 19:42:00 UTC) #2
rmacnak
On 2017/03/30 19:42:00, rmacnak wrote: (The iOS arm64 linker does not product such warnings.)
3 years, 8 months ago (2017-03-30 19:44:00 UTC) #3
Vyacheslav Egorov (Google)
lgtm
3 years, 8 months ago (2017-03-31 10:32:07 UTC) #4
rmacnak
3 years, 8 months ago (2017-03-31 20:37:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21e9a4fc650bb77ac5b28614f7e28c57a1cbc926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698