Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: components/favicon_base/favicon_callback.h

Issue 2784233003: [LargeIconService] Allow decoding of images in the service (Closed)
Patch Set: Minor changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon_base/favicon_callback.h
diff --git a/components/favicon_base/favicon_callback.h b/components/favicon_base/favicon_callback.h
index 96029f1c409e9a11fc569c8338bdb7804736ebb2..28ad5b3206db03c48a0d2347de8580813598e506 100644
--- a/components/favicon_base/favicon_callback.h
+++ b/components/favicon_base/favicon_callback.h
@@ -14,6 +14,7 @@ namespace favicon_base {
struct FaviconRawBitmapResult;
struct FaviconImageResult;
struct LargeIconResult;
+struct LargeIconImageResult;
// Callback for functions that can be used to return a |gfx::Image| and the
// |GURL| it is loaded from. They are returned as a |FaviconImageResult| object.
@@ -33,8 +34,16 @@ typedef base::Callback<void(const std::vector<FaviconRawBitmapResult>&)>
// Callback for functions returning data for a large icon. |LargeIconResult|
// will contain either the raw bitmap for a large icon or the style of the
// fallback to use if a sufficiently large icon could not be found.
+// TODO(jkrcal): Rename LargeIcon* to LargeIconRawBitmap*.
jkrcal 2017/03/31 12:31:11 Peter, do you agree with this renaming (in a follo
typedef base::Callback<void(const LargeIconResult&)> LargeIconCallback;
+// Callback for functions returning decoded data for a large icon.
+// |LargeIconImageResult| will contain either the decoded image of a large
+// icon or the style of the fallback to use if a sufficiently large icon could
+// not be found.
+typedef base::Callback<void(const LargeIconImageResult&)>
+ LargeIconImageCallback;
+
} // namespace favicon_base
#endif // COMPONENTS_FAVICON_BASE_FAVICON_CALLBACK_H_

Powered by Google App Engine
This is Rietveld 408576698