net/http/http_stream_factory_impl_request.cc - Issue 2784143003: Fix a potential infinite loop in HttpStreamFactoryImpl when a new SpdySession is established

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request.cc

Issue 2784143003: Fix a potential infinite loop in HttpStreamFactoryImpl when a new SpdySession is established (Closed)

Patch Set: Address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_request.cc

diff --git a/net/http/http_stream_factory_impl_request.cc b/net/http/http_stream_factory_impl_request.cc

index 76abed6add388def2342e627b4afbc70e944bd53..97ec79367c1e89265d3ab91d444f2898aefd9765 100644

--- a/net/http/http_stream_factory_impl_request.cc

+++ b/net/http/http_stream_factory_impl_request.cc

@@ -154,12 +154,6 @@ const ConnectionAttempts& HttpStreamFactoryImpl::Request::connection_attempts()

return connection_attempts_;

}

-void HttpStreamFactoryImpl::Request::ResetSpdySessionKey() {

- if (spdy_session_key_.get()) {

- spdy_session_key_.reset();

- }

bool HttpStreamFactoryImpl::Request::HasSpdySessionKey() const {

return spdy_session_key_.get() != NULL;

}