Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2784063002: Config changes to support target_os="fuchsia" (Closed)
Patch Set: rebase after s390 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index b05a8d746d8c5f0e2b9c84c2b3a16754672e65ef..7f6d1a311b6aed15222aaadc165c688f8032e1cc 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -169,6 +169,8 @@ config("compiler") {
configs += [ "//build/config/mac:compiler" ]
} else if (is_ios) {
configs += [ "//build/config/ios:compiler" ]
+ } else if (is_fuchsia) {
+ configs += [ "//build/config/fuchsia:compiler" ]
} else if (current_os == "aix") {
configs += [ "//build/config/aix:compiler" ]
}
@@ -309,7 +311,7 @@ config("compiler") {
# Linux/Android common flags setup.
# ---------------------------------
- if (is_linux || is_android) {
+ if (is_linux || is_android || is_fuchsia) {
if (use_pic) {
cflags += [ "-fPIC" ]
ldflags += [ "-fPIC" ]
@@ -339,7 +341,11 @@ config("compiler") {
"-lpthread",
]
}
- ldflags += [ "-Wl,--as-needed" ]
+ if (!is_fuchsia) {
jamesr1 2017/05/11 22:00:32 we can wrap just -lmxio with this, i.e. ldflags +
+ # We need mxio/magenta to get linked in, even if they're not directly
+ # referenced.
Nico 2017/05/11 15:03:16 Could you just add -l flags for those instead, to
scottmg 2017/05/11 16:36:10 Probably, yeah. Maybe what I'll do in this CL is j
+ ldflags += [ "-Wl,--as-needed" ]
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698