Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2784033002: Mark dwarf_stack_trace_test as flaky in product mode, due to identical code folding. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, regis
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark dwarf_stack_trace_test as flaky in product mode, due to identical code folding. Fix dwarf_stack_trace_test in checked mode (generated output directory includes a hypen). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/2343b9691130551560d889bfb3a85842ab0b48aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tests/standalone/dwarf_stack_trace_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 8 months ago (2017-03-29 20:30:03 UTC) #2
siva
lgtm
3 years, 8 months ago (2017-03-30 15:50:39 UTC) #3
rmacnak
3 years, 8 months ago (2017-03-30 17:01:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2343b9691130551560d889bfb3a85842ab0b48aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698