Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 278403003: Only commit cookie changes in prerenders after a prerender is shown (Closed)

Created:
6 years, 7 months ago by tburkard
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, skanuj+watch_chromium.org, felt, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, nasko+codewatch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, jam, dominich, darin-cc_chromium.org, erikwright (departed), chromium-apps-reviews_chromium.org, creis+watch_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, Jered, davidben+watch_chromium.org, donnd+watch_chromium.org, dominich+watch_chromium.org, eroman, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, mmenke
Visibility:
Public.

Description

Only commit cookie changes in prerenders after a prerender is shown Will create a PrerenderCookieStore for each prerender, retaining all cookie operations of a prerender until the prerender is shown to the user. Forces prerenders to be in a new render process by themselves for this to work. BUG=371003 This is a resubmission of https://codereview.chromium.org/233353003, which had to be reverted due to build breaks. See LGTM's there. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269855

Patch Set 1 #

Patch Set 2 : fix test issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1155 lines, -29 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 1 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 4 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 5 chunks +39 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 4 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/net/cookie_store_util.cc View 1 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/external_prerender_handler_android.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prerender/external_prerender_handler_android.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 5 chunks +129 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 4 chunks +24 lines, -3 lines 0 comments Download
A chrome/browser/prerender/prerender_cookie_store.h View 1 chunk +164 lines, -0 lines 0 comments Download
A chrome/browser/prerender/prerender_cookie_store.cc View 1 chunk +241 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_final_status.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_final_status.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 6 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 9 chunks +71 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_tracker.h View 1 3 chunks +36 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tracker.cc View 1 2 chunks +87 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/android/prerender/homepage.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/prerender/prerender_cookie.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/cookies/canonical_cookie.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M net/cookies/canonical_cookie.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M net/cookies/cookie_monster.h View 1 5 chunks +20 lines, -4 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 6 chunks +61 lines, -2 lines 0 comments Download
M net/cookies/cookie_monster_store_test.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/cookies/cookie_monster_store_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tburkard
Committed patchset #2 manually as r269855.
6 years, 7 months ago (2014-05-12 20:00:35 UTC) #1
piman
This broke again - http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=23472 Please don't reland manually without a full round of trybots, ...
6 years, 7 months ago (2014-05-12 21:21:44 UTC) #2
tburkard
6 years, 7 months ago (2014-05-12 21:33:48 UTC) #3
Sorry about that.

Will be more careful.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698