Add IsSupportedAudioConfig in MediaClient

chromecast/common/media/cast_media_client.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/common/media/cast_media_client.h"
 
+#include "chromecast/media/base/media_caps.h"
 #include "chromecast/media/base/media_codec_support.h"
 #include "chromecast/media/base/supported_codec_profile_levels_memo.h"
 #include "chromecast/public/media/media_capabilities_shlib.h"
 
 // TODO(servolk): Is there a better way to override just IsSupportedVideoConfig
 // without duplicating content::RenderMediaClient implementation?
 // For now use this to allow access to the ::media::GetMediaClient.
 namespace media {
 MEDIA_EXPORT MediaClient* GetMediaClient();
 }
@@ skipping 47 matching lines @@
   return supported_profiles_->IsSupportedVideoConfig(
       ToCastVideoCodec(config.codec, config.profile),
       ToCastVideoProfile(config.profile), config.level);
 #else
   return MediaCapabilitiesShlib::IsSupportedVideoConfig(
       ToCastVideoCodec(config.codec, config.profile),
       ToCastVideoProfile(config.profile), config.level);
 #endif
 }
 
+bool CastMediaClient::IsSupportedAudioConfig(
+    const ::media::AudioConfig& config) {
+#if defined(OS_ANDROID)
+  // TODO(sanfin): Implement this for Android.

[gfhuang, 2017/03/29 20:54:59]

Open a bug to sanfin@ so that this doesn't fall through the crack.


BTW, in case you don't know.
TODO label means "who knows what to do", not "who is going to do".

[servolk, 2017/03/29 21:51:52]

Done (b/36734043).

I think it's pretty obvious in this case what needs to be done, so Simeon
hopefully know what to do in this case too :)

+  return true;
+#else
+  AudioCodec codec = ToCastAudioCodec(config.codec);
+  // Cast platform implements software decoding of Opus and FLAC, so only PCM
+  // support is necessary in order to support Opus and FLAC.
+  if (codec == kCodecOpus || codec == kCodecFLAC)
+    codec = kCodecPCM;
+
+  // If HDMI sink supports AC3/EAC3 codecs then we don't need the vendor backend
+  // to support these codec directly.
+  if (codec == kCodecEAC3 && MediaCapabilities::HdmiSinkSupportsEAC3())

[gfhuang, 2017/03/29 20:54:58]

is this defaults to true for non-HDMI TV device?

[servolk, 2017/03/29 21:51:52]

No, this is solely for HDMI devices. TVs that support AC3/EAC3 internally should
handle the kCodecAC3 / kCodecEAC3 explicitly in their
MediaCapShlib::IsSupportedAudioConfig implementations.

[gfhuang, 2017/03/29 21:57:28]

I see. then please double-check
MediaCapabilities::HdmiSinkSupportsEAC3() is return false by default in CastTVs.
so that the code will keep going to L96

+    return true;
+  if (codec == kCodecAC3 && MediaCapabilities::HdmiSinkSupportsAC3())
+    return true;
+
+  AudioConfig cast_audio_config;
+  cast_audio_config.codec = codec;
+  return MediaCapabilitiesShlib::IsSupportedAudioConfig(cast_audio_config);
+#endif
+}
+
 }  // namespace media
 }  // namespace chromecast