Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart

Issue 2783933002: Fix many warnings/errors when building Observatory (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/debugger.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart
diff --git a/runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart b/runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart
index 3eed1fb738df1ecb8ad2a8d5cd009770bf8a05ca..00c55b9be3d31ff8aa38745ef439c5511b07d5c8 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart
+++ b/runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart
@@ -49,8 +49,7 @@ class CpuProfileVirtualTreeElement extends HtmlElement implements Renderable {
_r.dirty();
}
- factory CpuProfileVirtualTreeElement(
- M.IsolateRef isolate, M.SampleProfile profile,
+ factory CpuProfileVirtualTreeElement(Object owner, M.SampleProfile profile,
{ProfileTreeMode mode: ProfileTreeMode.function,
M.SampleProfileType type: M.SampleProfileType.cpu,
M.ProfileTreeDirection direction: M.ProfileTreeDirection.exclusive,
@@ -60,7 +59,7 @@ class CpuProfileVirtualTreeElement extends HtmlElement implements Renderable {
assert(direction != null);
CpuProfileVirtualTreeElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
- e._isolate = isolate;
+ e._isolate = owner;
e._profile = profile;
e._mode = mode;
e._type = type;
@@ -117,7 +116,6 @@ class CpuProfileVirtualTreeElement extends HtmlElement implements Renderable {
break;
default:
throw new Exception('Unknown SampleProfileType: $type');
- break;
rmacnak 2017/03/29 17:20:44 I think the analyzer has gone back and forth on wh
}
if (filters != null) {
tree = filters.fold(tree, (tree, filter) {
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/debugger.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698