Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2783933002: Fix many warnings/errors when building Observatory (Closed)

Created:
3 years, 8 months ago by Cutch
Modified:
3 years, 8 months ago
Reviewers:
bkonyi, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix many warnings/errors when building Observatory BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/66aca8a36e0a18abd56f9509329ce445451ee4fc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 3 chunks +2 lines, -4 lines 1 comment Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/sample_profile.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/thread.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/vm.dart View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/sample_profile.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +6 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/heap_snapshot.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/vm.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/heap_snapshot.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
3 years, 8 months ago (2017-03-29 17:15:40 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2783933002/diff/1/runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart File runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart (left): https://codereview.chromium.org/2783933002/diff/1/runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart#oldcode120 runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:120: break; I think the analyzer has gone back ...
3 years, 8 months ago (2017-03-29 17:20:44 UTC) #4
Cutch
3 years, 8 months ago (2017-03-29 17:31:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66aca8a36e0a18abd56f9509329ce445451ee4fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698