chrome/browser/extensions/unpacked_installer.cc - Issue 2783813002: Move ChromeRequirementsChecker to //extensions as a PreloadCheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 2783813002: Move ChromeRequirementsChecker to //extensions as a PreloadCheck (Closed)

Patch Set: minor test cleanup Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index 148113f36b5a782b3695c9501369db66452e438c..109d0a046e32a244fc43707e5ea0cdeba8dcca07 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -258,9 +258,8 @@ void UnpackedInstaller::OnInstallChecksComplete(int failed_checks) {

return;

}

- if (!install_checker_->requirement_errors().empty()) {

- ReportExtensionLoadError(

- base::JoinString(install_checker_->requirement_errors(), " "));

+ if (!install_checker_->requirements_error_message().empty()) {

+ ReportExtensionLoadError(install_checker_->requirements_error_message());

return;

}