Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2783773002: Link PasswordProtectionService to Profile and SB Service (Closed)
Patch Set: refine histogram description Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_reuse_detection_manager.cc
diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc
index afd1a8e5035488021385296c40faf4eb227f68ad..ab55375398fa608fb4a02e89179f6ecb10642162 100644
--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc
+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc
@@ -27,13 +27,6 @@ PasswordReuseDetectionManager::PasswordReuseDetectionManager(
PasswordReuseDetectionManager::~PasswordReuseDetectionManager() {}
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
-void PasswordReuseDetectionManager::SetPasswordProtectionService(
- base::WeakPtr<safe_browsing::PasswordProtectionService> pp_service) {
- password_protection_service_ = pp_service;
-}
-#endif
-
void PasswordReuseDetectionManager::DidNavigateMainFrame(
const GURL& main_frame_url) {
main_frame_url_ = main_frame_url;
@@ -70,9 +63,12 @@ void PasswordReuseDetectionManager::OnReuseFound(
metrics_util::LogPasswordReuse(
password.size(), saved_passwords, number_matches,
client_->GetPasswordManager()->IsPasswordFieldDetectedOnPage());
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
- if (password_protection_service_)
- password_protection_service_->RecordPasswordReuse(main_frame_url_);
+#if defined(SAFE_BROWSING_DB_LOCAL)
+ // TODO(jialiul): After CSD whitelist being added to Android, we should gate
+ // this by either SAFE_BROWSING_DB_LOCAL or SAFE_BROWSING_DB_REMOTE.
+ safe_browsing::PasswordProtectionService* password_protection_service =
+ client_->GetPasswordProtectionService();
+ password_protection_service->RecordPasswordReuse(main_frame_url_);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698