Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3193)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 2783773002: Link PasswordProtectionService to Profile and SB Service (Closed)
Patch Set: refine histogram description Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 76067385eec136da094971e6d8efe4917cf52edb..d77147e09aeeb869ee4eb6731c8756a02f209b79 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -186,16 +186,6 @@ ChromePasswordManagerClient::ChromePasswordManagerClient(
password_manager::prefs::kCredentialsEnableService, GetPrefs());
ReportMetrics(*saving_and_filling_passwords_enabled_, this, profile_);
driver_factory_->RequestSendLoggingAvailability();
-
-#if (defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)) && \
- !defined(OS_ANDROID) && !defined(OS_IOS)
- if (CanSetPasswordProtectionService()) {
- password_reuse_detection_manager_.SetPasswordProtectionService(
- g_browser_process->safe_browsing_service()
- ->password_protection_service()
- ->GetWeakPtr());
- }
-#endif
}
ChromePasswordManagerClient::~ChromePasswordManagerClient() {}
@@ -411,6 +401,17 @@ void ChromePasswordManagerClient::HidePasswordGenerationPopup() {
popup_controller_->HideAndDestroy();
}
+#if defined(SAFE_BROWSING_DB_LOCAL)
+safe_browsing::PasswordProtectionService*
+ChromePasswordManagerClient::GetPasswordProtectionService() const {
+ if (g_browser_process && g_browser_process->safe_browsing_service()) {
+ return g_browser_process->safe_browsing_service()
+ ->GetPasswordProtectionService(profile_);
+ }
+ return nullptr;
+}
+#endif
+
// TODO(crbug.com/706392): Fix password reuse detection for Android.
#if !defined(OS_ANDROID)
void ChromePasswordManagerClient::DidFinishNavigation(
@@ -634,14 +635,6 @@ bool ChromePasswordManagerClient::ShouldAnnotateNavigationEntries(
return true;
}
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
-bool ChromePasswordManagerClient::CanSetPasswordProtectionService() {
- return g_browser_process && g_browser_process->safe_browsing_service() &&
- g_browser_process->safe_browsing_service()
- ->password_protection_service();
-}
-#endif
-
void ChromePasswordManagerClient::AnnotateNavigationEntry(
bool has_password_field) {
if (!ShouldAnnotateNavigationEntries(profile_))

Powered by Google App Engine
This is Rietveld 408576698