tools/metrics/histograms/histograms.xml - Issue 2783773002: Link PasswordProtectionService to Profile and SB Service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2783773002: Link PasswordProtectionService to Profile and SB Service (Closed)

Patch Set: add a UMA metric to track the number of cached verdict before shutdown Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 0a7235dd97d4838a73d7f3a210be62cece41a37e..6337bfb96f70bdb0887f3a961eb2e0bf02eb32f3 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -48087,6 +48087,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PasswordProtection.NumberOfCachedVerdictBeforeShutdown">

Mark P 2017/04/05 18:39:28 units=?

Jialiu Lin 2017/04/05 19:00:02 units="count"

+ <owner>jialiul@chromium.org</owner>

+ <owner>nparker@chromium.org</owner>

+ <summary>

+ Number of cached verdict of a profile before destructing

Mark P 2017/04/05 18:39:28 What is a "cached verdict"

Jialiu Lin 2017/04/05 19:00:02 it refers to the password protection verdict we st

+ PasswordProtectionService.

Mark P 2017/04/05 18:39:28 Roughly when is a PasswordProtectionService destru

Jialiu Lin 2017/04/05 19:00:02 It is destructed with its corresponding user profi

+ </summary>

+</histogram>

<histogram name="PasswordProtection.PasswordProtectionResponseOrErrorCode"

enum="CombinedHttpResponseAndNetErrorCode">

<owner>jialiul@chromium.org</owner>

@@ -122782,6 +122791,7 @@ from previous Chrome versions.

label="Malware interstitial referrer attribution."/>

<suffix name="UwsInterstitialAttribution"

label="UwS interstitial referrer attribution."/>

+ <suffix name="PasswordEventAttribution"/>

<affected-histogram name="SafeBrowsing.ReferrerAttributionResult"/>

<affected-histogram name="SafeBrowsing.ReferrerHasInvalidTabID"/>

<affected-histogram name="SafeBrowsing.ReferrerURLChainSize"/>

« no previous file with comments | « components/safe_browsing/password_protection/password_protection_service_unittest.cc ('k') | no next file » | no next file with comments »