Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: device/bluetooth/test/bluetooth_test_mac.mm

Issue 2783733002: Bluetooth: Add service data unit tests for chromeos (Closed)
Patch Set: comments and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/test/bluetooth_test_bluez.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/test/bluetooth_test_mac.mm
diff --git a/device/bluetooth/test/bluetooth_test_mac.mm b/device/bluetooth/test/bluetooth_test_mac.mm
index 777e91339cf66d8d512b200378f7e9f0ebc7f116..04c61e33226d28cdcb17d547b7de815907a23464 100644
--- a/device/bluetooth/test/bluetooth_test_mac.mm
+++ b/device/bluetooth/test/bluetooth_test_mac.mm
@@ -176,9 +176,9 @@ BluetoothDevice* BluetoothTestMac::SimulateLowEnergyDevice(int device_ordinal) {
];
service_data = @{
[CBUUID UUIDWithString:@(kTestUUIDHeartRate.c_str())] :
- [NSData dataWithBytes:(unsigned char[]){2} length:1],
ortuno 2017/04/03 23:55:51 Ah seems like we need to fix the test data for the
+ [NSData dataWithBytes:(unsigned char[]){} length:0],
[CBUUID UUIDWithString:@(kTestUUIDImmediateAlert.c_str())] :
- [NSData dataWithBytes:(unsigned char[]){0} length:1]
+ [NSData dataWithBytes:(unsigned char[]){0, 2} length:2]
};
tx_power = @(static_cast<int8_t>(TestTxPower::LOWER));
break;
« no previous file with comments | « device/bluetooth/test/bluetooth_test_bluez.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698